commit edb6b6842cbddc012d64491701f1d0979ffa96b3
author Heinrich Schuchardt <xypron.glpk@gmx.de> Mon Sep 23 22:18:09 2019 +0200
committer Heinrich Schuchardt <xypron.glpk@gmx.de> Mon Sep 23 22:53:25 2019 +0200
tree a74a01735f4a354e84a9463489d442b6484af3cb
parent be09372a71ceeabf6762e84c33e9be96bafeb272

efi_loader: SetVariable() fix illegal return

We always have to return via EFI_EXIT() from EFIAPI functions.

Coverity reported an unreachable line and a resource leak.

Fixes: commit 6d2f27c5fd60 ("efi_loader: variable: support APPEND_WRITE")
Reported-by: Coverity Scan CID 253575, CID 184095
Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>

lib/efi_loader/efi_variable.c

diff --git a/lib/efi_loader/efi_variable.c b/lib/efi_loader/efi_variable.c
index 48ee255..22ad271 100644
--- a/lib/efi_loader/efi_variable.c
+++ b/lib/efi_loader/efi_variable.c
@@ -470,7 +470,7 @@
 
 		if (attributes & EFI_VARIABLE_APPEND_WRITE) {
 			if (!prefix(old_val, "(blob)")) {
-				return EFI_DEVICE_ERROR;
+				ret = EFI_DEVICE_ERROR;
 				goto out;
 			}
 			old_size = strlen(old_val);