commit a84b886a7d588e5eb54b4ca5a9c5538b9555556f
author Nicolas Dufresne <nicolas.dufresne@collabora.com> Wed Feb 21 22:01:36 2018 -0500
committer Nicolas Dufresne <nicolas.dufresne@collabora.com> Thu Feb 22 16:14:57 2018 -0500
tree a3d2d1dc90a55df3617ba118fbdb7ab599e04e8c
parent 25aed8c7ff79499ef7520f7f4d023cfcc0ead808

baseparse: Avoid overflow in update_interval calculation

https://bugzilla.gnome.org/show_bug.cgi?id=793284

libs/gst/base/gstbaseparse.c

diff --git a/libs/gst/base/gstbaseparse.c b/libs/gst/base/gstbaseparse.c
index 5c44454..7ad1212 100644
--- a/libs/gst/base/gstbaseparse.c
+++ b/libs/gst/base/gstbaseparse.c
@@ -3860,7 +3860,11 @@
         gst_util_uint64_scale (GST_SECOND, fps_den * lead_out, fps_num);
     /* aim for about 1.5s to estimate duration */
     if (parse->priv->update_interval < 0) {
-      parse->priv->update_interval = fps_num * 3 / (fps_den * 2);
+      guint64 interval = gst_util_uint64_scale (fps_num, 3,
+          G_GUINT64_CONSTANT (2) * fps_den);
+
+      parse->priv->update_interval = MIN (interval, G_MAXINT);
+
       GST_LOG_OBJECT (parse, "estimated update interval to %d frames",
           parse->priv->update_interval);
     }