commit e6aa495ae2fcbdc6ca503b025e92dd1b124ff14f
author Edward Hervey <edward@centricular.com> Wed Jun 20 10:03:59 2018 +0200
committer Tim-Philipp Müller <tim@centricular.com> Wed Jul 18 15:09:08 2018 +0100
tree 4c8d72c3b3263d7ebe7d5de67c9b9bfa2ddc702c
parent da4aa408e3dc7cd08cd30caaffb71d8af8949f5c

souphttpsrc: Protect input stream with lock

This was the last remaining place where modifying/unreffing the
input stream was not protected by the lock

https://bugzilla.gnome.org/show_bug.cgi?id=796639

ext/soup/gstsouphttpsrc.c

diff --git a/ext/soup/gstsouphttpsrc.c b/ext/soup/gstsouphttpsrc.c
index 28642e3..6e64a57 100644
--- a/ext/soup/gstsouphttpsrc.c
+++ b/ext/soup/gstsouphttpsrc.c
@@ -454,10 +454,12 @@
   src->increase_blocksize_count = 0;
 
   g_cancellable_reset (src->cancellable);
+  g_mutex_lock (&src->mutex);
   if (src->input_stream) {
     g_object_unref (src->input_stream);
     src->input_stream = NULL;
   }
+  g_mutex_unlock (&src->mutex);
 
   gst_caps_replace (&src->src_caps, NULL);
   g_free (src->iradio_name);
@@ -1519,6 +1521,7 @@
   return TRUE;
 }
 
+/* Lock taken */
 static GstFlowReturn
 gst_soup_http_src_send_message (GstSoupHTTPSrc * src)
 {
@@ -1526,6 +1529,7 @@
   GError *error = NULL;
 
   g_return_val_if_fail (src->msg != NULL, GST_FLOW_ERROR);
+  g_assert (src->input_stream == NULL);
 
   src->input_stream =
       soup_session_send (src->session, src->msg, src->cancellable, &error);