commit 9367710702af01166d433cb2973febcf0a45e541
author Nicolas Dufresne <nicolas@ndufresne.ca> Tue Sep 11 00:18:32 2018 +0000
committer Nicolas Dufresne <nicolas.dufresne@collabora.com> Mon Sep 10 20:30:17 2018 -0400
tree 116f28b96c74c2960b6a62d487ba099eb1103f15
parent e69d2c8ccadda37cef158110d0a01bf60f37fd45

v4l2object: Protect against zero PAR num/demu

This fixes an assertion when the driver implement CROPCAP but does
not set the PAR.

sys/v4l2/gstv4l2object.c

diff --git a/sys/v4l2/gstv4l2object.c b/sys/v4l2/gstv4l2object.c
index 5d3b691..124c778 100644
--- a/sys/v4l2/gstv4l2object.c
+++ b/sys/v4l2/gstv4l2object.c
@@ -4180,7 +4180,7 @@
         GST_WARNING_OBJECT (v4l2object->dbg_obj,
             "Failed to probe pixel aspect ratio with VIDIOC_CROPCAP: %s",
             g_strerror (errno));
-    } else {
+    } else if (cropcap.pixelaspect.numerator && cropcap.pixelaspect.denominator) {
       v4l2object->par = g_new0 (GValue, 1);
       g_value_init (v4l2object->par, GST_TYPE_FRACTION);
       gst_value_set_fraction (v4l2object->par, cropcap.pixelaspect.numerator,