commit eb630c97eddb6911bdc8ca52ee887d816c7b810b
author Sebastian Dröge <sebastian@centricular.com> Fri Jul 06 10:51:37 2018 +0300
committer Tim-Philipp Müller <tim@centricular.com> Wed Jul 18 14:31:33 2018 +0100
tree 43a7df07daee9c6db5e1191359819cd333468b0d
parent d6271b4dab9b503c4b3273b97877512e81b93f89

parsebin: Don't try to continue autoplugging a parser if we got raw caps

Otherwise we'll fail with an unhelpful message that no decoder for the
raw caps was found if a container contains raw media.

gst/playback/gstparsebin.c

diff --git a/gst/playback/gstparsebin.c b/gst/playback/gstparsebin.c
index 0cfd5ca..87ee11f 100644
--- a/gst/playback/gstparsebin.c
+++ b/gst/playback/gstparsebin.c
@@ -106,6 +106,7 @@
 #include "gstplay-enum.h"
 #include "gstplayback.h"
 #include "gstplaybackutils.h"
+#include "gstrawcaps.h"
 
 /* generic templates */
 static GstStaticPadTemplate parse_bin_sink_template =
@@ -1106,9 +1107,18 @@
 gst_parse_bin_autoplug_continue (GstElement * element, GstPad * pad,
     GstCaps * caps)
 {
+  static GstStaticCaps raw_caps = GST_STATIC_CAPS (DEFAULT_RAW_CAPS);
+
+  GST_DEBUG_OBJECT (element, "caps %" GST_PTR_FORMAT, caps);
+
+  /* If it matches our target caps, expose it */
+  if (gst_caps_can_intersect (caps, gst_static_caps_get (&raw_caps))) {
+    GST_DEBUG_OBJECT (element, "autoplug-continue returns FALSE");
+    return FALSE;
+  }
+
   GST_DEBUG_OBJECT (element, "autoplug-continue returns TRUE");
 
-  /* by default we always continue */
   return TRUE;
 }