commit 8705d9b63ed7c357a8645031eb3b9a1639b17bcb
author Thibault Saunier <tsaunier@igalia.com> Tue Apr 10 09:31:32 2018 -0300
committer Sebastian Dröge <sebastian@centricular.com> Mon Apr 16 11:07:28 2018 +0300
tree 39dad52d61e5fb725436d54a33da7bc408269b4c
parent 947a2627c534982be20ea151c3051b7cb9dd0b83

urisourcebin: Avoid unreffing a pad we are not owning

expose_output_pad takes ownership of the pad.

gst/playback/gsturisourcebin.c

diff --git a/gst/playback/gsturisourcebin.c b/gst/playback/gsturisourcebin.c
index 3e0d26d..0016218 100644
--- a/gst/playback/gsturisourcebin.c
+++ b/gst/playback/gsturisourcebin.c
@@ -1454,13 +1454,16 @@
             gst_object_unref (pad);
             pad = slot->srcpad;
           } else {
-            pad = create_output_pad (urisrc, pad);
+            GstPad *tmppad = create_output_pad (urisrc, pad);
+            gst_object_unref (pad);
+
+            pad = tmppad;
           }
           GST_URI_SOURCE_BIN_UNLOCK (urisrc);
           expose_output_pad (urisrc, pad);
+        } else {
           gst_object_unref (pad);
         }
-        gst_object_unref (pad);
         g_value_reset (&item);
         break;
     }