commit 3fd7b04e169fb577d40281d07bbc01d62713efd5
author Edward Hervey <edward@centricular.com> Wed May 30 11:39:40 2018 +0200
committer Tim-Philipp Müller <tim@centricular.com> Wed Jul 18 14:24:41 2018 +0100
tree 6fac19aaf0addd3210eab0f56e3842f0523b8e35
parent d68164e6f398b9a1420ad2c5b3a45e241931d2cf

subparse: Don't read beyond array

If num_open_tags is 0, we shouldn't try to get the "last" open tag
since there isn't any.

gst/subparse/gstsubparse.c

diff --git a/gst/subparse/gstsubparse.c b/gst/subparse/gstsubparse.c
index 58d7606..c527a94 100644
--- a/gst/subparse/gstsubparse.c
+++ b/gst/subparse/gstsubparse.c
@@ -816,7 +816,9 @@
     if (*next_tag == '<' && *(next_tag + 1) == '/') {
       end_tag = strchr (cur, '>');
       if (end_tag) {
-        const gchar *last = g_ptr_array_index (open_tags, num_open_tags - 1);
+        const gchar *last = NULL;
+        if (num_open_tags > 0)
+          last = g_ptr_array_index (open_tags, num_open_tags - 1);
         if (num_open_tags == 0
             || g_ascii_strncasecmp (end_tag - 1, last, strlen (last))) {
           GST_LOG ("broken input, closing tag '%s' is not open", end_tag - 1);