commit c65a537a81743d3115655fc7212dee266fa97540
author Seungha Yang <pudding8757@gmail.com> Fri Apr 06 23:22:39 2018 +0900
committer Nicolas Dufresne <nicolas.dufresne@collabora.com> Wed Apr 11 22:48:09 2018 -0400
tree 1aa045b352235dd6a8d4368f2119f7b9909e372d
parent 5a3e122e6f82f706349df10ea051c54925a82338

h265parse: Make caps writable before modifying them

Fix following assertion failure
GStreamer-CRITICAL **: gst_structure_remove_field: assertion 'IS_MUTABLE (structure)' failed

https://bugzilla.gnome.org/show_bug.cgi?id=795032

gst/videoparsers/gsth265parse.c

diff --git a/gst/videoparsers/gsth265parse.c b/gst/videoparsers/gsth265parse.c
index 46de66f..d68423e 100644
--- a/gst/videoparsers/gsth265parse.c
+++ b/gst/videoparsers/gsth265parse.c
@@ -2268,8 +2268,10 @@
   }
 
   /* Try if we can put the downstream caps first */
-  remove_fields (peercaps, FALSE);
-  tmp = gst_caps_intersect_full (peercaps, res, GST_CAPS_INTERSECT_FIRST);
+  pcopy = gst_caps_copy (peercaps);
+  remove_fields (pcopy, FALSE);
+  tmp = gst_caps_intersect_full (pcopy, res, GST_CAPS_INTERSECT_FIRST);
+  gst_caps_unref (pcopy);
   if (!gst_caps_is_empty (tmp))
     res = gst_caps_merge (tmp, res);
   else