commit c2956036b8da4b8f22a63a4f5a254be03e870aa6
author Nirbheek Chauhan <nirbheek@centricular.com> Thu Mar 01 15:29:27 2018 +0530
committer Nirbheek Chauhan <nirbheek@centricular.com> Thu Mar 01 15:33:18 2018 +0530
tree 35f66536afa04e0234f16889e68a3a62e3ed1d59
parent 7771488edb4bf57589ed63f5f998d1a28de38677

wasapi: Increase rank to prefer over directsoundsrc

Directsoundsrc/sink have multiple issues, most of which cannot be
fixed at all because the API is deprecated and is implemented as a
compatibility wrapper around WASAPI since Vista.

Users and developers should now use the wasapisrc/sink elements, and
future development efforts should go towards that.

sys/directsound/gstdirectsoundplugin.c

diff --git a/sys/directsound/gstdirectsoundplugin.c b/sys/directsound/gstdirectsoundplugin.c
index 66d6c40..1c0f410 100644
--- a/sys/directsound/gstdirectsoundplugin.c
+++ b/sys/directsound/gstdirectsoundplugin.c
@@ -35,7 +35,7 @@
 static gboolean
 plugin_init (GstPlugin * plugin)
 {
-  if (!gst_element_register (plugin, "directsoundsrc", GST_RANK_PRIMARY,
+  if (!gst_element_register (plugin, "directsoundsrc", GST_RANK_SECONDARY,
           GST_TYPE_DIRECTSOUND_SRC))
     return FALSE;
 

sys/wasapi/gstwasapi.c

diff --git a/sys/wasapi/gstwasapi.c b/sys/wasapi/gstwasapi.c
index 6669797..72ebd53 100644
--- a/sys/wasapi/gstwasapi.c
+++ b/sys/wasapi/gstwasapi.c
@@ -1,5 +1,7 @@
 /*
  * Copyright (C) 2008 Ole André Vadla Ravnås <ole.andre.ravnas@tandberg.com>
+ * Copyright (C) 2018 Centricular Ltd.
+ *   Author: Nirbheek Chauhan <nirbheek@centricular.com>
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
@@ -30,11 +32,11 @@
 static gboolean
 plugin_init (GstPlugin * plugin)
 {
-  if (!gst_element_register (plugin, "wasapisink", GST_RANK_NONE,
+  if (!gst_element_register (plugin, "wasapisink", GST_RANK_PRIMARY,
           GST_TYPE_WASAPI_SINK))
     return FALSE;
 
-  if (!gst_element_register (plugin, "wasapisrc", GST_RANK_NONE,
+  if (!gst_element_register (plugin, "wasapisrc", GST_RANK_PRIMARY,
           GST_TYPE_WASAPI_SRC))
     return FALSE;