commit c187a097c81b7628e129663c6d88fcdc09805b4f
author Nirbheek Chauhan <nirbheek@centricular.com> Wed Apr 18 15:03:19 2018 +0530
committer Nirbheek Chauhan <nirbheek@centricular.com> Wed Apr 18 15:05:09 2018 +0530
tree c27347ec6f50d3b6bb26baa9f94994d2796fc7a9
parent 3f90235aaa36d78aada6adb59c3e333bfe9865a8

wasapisrc: Don't provide a clock based on WASAPI's clock

The clock seems to have a lot of drift (or we're using it incorrectly)
which causes buffers to be late on the sink and get dropped.

Disable till someone can investigate whether our usage of the API is
incorrect (it looked correct to me) or if something is wrong.

sys/wasapi/gstwasapisrc.c

diff --git a/sys/wasapi/gstwasapisrc.c b/sys/wasapi/gstwasapisrc.c
index 3170845..1dbbc82 100644
--- a/sys/wasapi/gstwasapisrc.c
+++ b/sys/wasapi/gstwasapisrc.c
@@ -56,6 +56,9 @@
 #define DEFAULT_EXCLUSIVE     FALSE
 #define DEFAULT_LOW_LATENCY   FALSE
 #define DEFAULT_AUDIOCLIENT3  FALSE
+/* The clock provided by WASAPI is always off and causes buffers to be late
+ * very quickly on the sink. Disable pending further investigation. */
+#define DEFAULT_PROVIDE_CLOCK FALSE
 
 enum
 {
@@ -86,8 +89,10 @@
 static guint gst_wasapi_src_delay (GstAudioSrc * asrc);
 static void gst_wasapi_src_reset (GstAudioSrc * asrc);
 
+#ifdef DEFAULT_PROVIDE_CLOCK
 static GstClockTime gst_wasapi_src_get_time (GstClock * clock,
     gpointer user_data);
+#endif
 
 #define gst_wasapi_src_parent_class parent_class
 G_DEFINE_TYPE (GstWasapiSrc, gst_wasapi_src, GST_TYPE_AUDIO_SRC);
@@ -160,6 +165,7 @@
 static void
 gst_wasapi_src_init (GstWasapiSrc * self)
 {
+#ifdef DEFAULT_PROVIDE_CLOCK
   /* override with a custom clock */
   if (GST_AUDIO_BASE_SRC (self)->clock)
     gst_object_unref (GST_AUDIO_BASE_SRC (self)->clock);
@@ -167,6 +173,7 @@
   GST_AUDIO_BASE_SRC (self)->clock = gst_audio_clock_new ("GstWasapiSrcClock",
       gst_wasapi_src_get_time, gst_object_ref (self),
       (GDestroyNotify) gst_object_unref);
+#endif
 
   self->role = DEFAULT_ROLE;
   self->sharemode = AUDCLNT_SHAREMODE_SHARED;
@@ -473,6 +480,9 @@
   hr = IAudioClock_GetFrequency (self->client_clock, &self->client_clock_freq);
   HR_FAILED_GOTO (hr, IAudioClock::GetFrequency, beach);
 
+  GST_INFO_OBJECT (self, "wasapi clock freq is %" G_GUINT64_FORMAT,
+      self->client_clock_freq);
+
   /* Get capture source client and start it up */
   if (!gst_wasapi_util_get_capture_client (GST_ELEMENT (self), self->client,
           &self->capture_client)) {
@@ -652,6 +662,7 @@
   GST_OBJECT_UNLOCK (self);
 }
 
+#ifdef DEFAULT_PROVIDE_CLOCK
 static GstClockTime
 gst_wasapi_src_get_time (GstClock * clock, gpointer user_data)
 {
@@ -678,3 +689,4 @@
 
   return result;
 }
+#endif