commit 6eef7b71683297835bdd8787b07915b6d198f963
author Nicolas Dufresne <nicolas.dufresne@collabora.com> Wed Apr 25 15:05:38 2018 -0400
committer Sebastian Dröge <sebastian@centricular.com> Sat Apr 28 10:47:01 2018 +0300
tree 7484c0c1305eb9d64638cad3ead4868b52e03757
parent 4f2696c5f649b3efd33d2f17e781e33803ce00dc

rfbsrc: Fix decide_allocation to support NULL pool

We were assuming that NULL pool meant that downstream didn't reply.
Update the pool index 0 instead of adding at the end. Otherwise we ended
up letting basesrc decide, which would pick the blocksize as a size
(4096) instead of the image size.

https://bugzilla.gnome.org/show_bug.cgi?id=795327

gst/librfb/gstrfbsrc.c

diff --git a/gst/librfb/gstrfbsrc.c b/gst/librfb/gstrfbsrc.c
index 786d32d..9c9b5ab 100644
--- a/gst/librfb/gstrfbsrc.c
+++ b/gst/librfb/gstrfbsrc.c
@@ -372,7 +372,11 @@
     size = info.size;
     min = 1;
     max = 0;
-    gst_query_add_allocation_pool (query, pool, size, min, max);
+
+    if (gst_query_get_n_allocation_pools (query) > 0)
+      gst_query_set_nth_allocation_pool (query, 0, pool, size, min, max);
+    else
+      gst_query_add_allocation_pool (query, pool, size, min, max);
   }
 
   config = gst_buffer_pool_get_config (pool);