commit 479b1ef76ba1a2d4c5198806b6c3e2e7dd434ae1
author Lyon Wang <lyon.wang@nxp.com> Mon Jun 04 16:35:41 2018 +0800
committer Sebastian Dröge <sebastian@centricular.com> Thu Jun 21 13:38:31 2018 +0300
tree 2b0f0889333324b5a787003f5ebaf9bfc77236e0
parent b8a4b49b2a96504d8a0e9795e28d9f895faad016

player: Fix duration-changed CRITICAL warning if duration did not actually change

Check if duration is changed before emitting duration-changed signal

https://bugzilla.gnome.org/show_bug.cgi?id=796491

gst-libs/gst/player/gstplayer.c

diff --git a/gst-libs/gst/player/gstplayer.c b/gst-libs/gst/player/gstplayer.c
index 8dac3e9..5dd340a 100644
--- a/gst-libs/gst/player/gstplayer.c
+++ b/gst-libs/gst/player/gstplayer.c
@@ -1499,7 +1499,8 @@
 {
   gboolean updated = FALSE;
 
-  g_return_if_fail (self->cached_duration != duration);
+  if (self->cached_duration == duration)
+    return;
 
   GST_DEBUG_OBJECT (self, "Duration changed %" GST_TIME_FORMAT,
       GST_TIME_ARGS (duration));