commit 2c01338e917f2acb9043f03cdd40501ff4c1421b
author Christoph Reiter <reiter.christoph@gmail.com> Tue May 22 22:58:22 2018 +0200
committer Nirbheek Chauhan <nirbheek@centricular.com> Wed May 23 13:25:59 2018 +0530
tree c4241316ac7f4c0056f1e86b23875255ca6edffa
parent aa77cac8ecd9f2b736c5b9278c453114c14efcd3

wasapi: use FAILED to detect errors

S_FALSE is a valid return value which does not indicate an error.
For example IAudioClient_Stop() returns S_FALSE when it is already stopped.
Use the FAILED macro instead which just checks if an error occured or not.

This fixes spurious warnings when using the wasapisink element.

https://bugzilla.gnome.org/show_bug.cgi?id=796280

sys/wasapi/gstwasapiutil.h

diff --git a/sys/wasapi/gstwasapiutil.h b/sys/wasapi/gstwasapiutil.h
index d6049a3..d525a92 100644
--- a/sys/wasapi/gstwasapiutil.h
+++ b/sys/wasapi/gstwasapiutil.h
@@ -43,7 +43,7 @@
 /* Standard error path */
 #define HR_FAILED_AND(hr,func,and) \
   do { \
-    if (hr != S_OK) { \
+    if (FAILED (hr)) { \
       gchar *msg = gst_wasapi_util_hresult_to_string (hr); \
       GST_ERROR_OBJECT (self, #func " failed (%x): %s", (guint) hr, msg); \
       g_free (msg); \