commit 23f5c02ce1d21e02feff93111fff2d370bb089fe
author Edward Hervey <edward@centricular.com> Sat May 19 11:03:08 2018 +0200
committer Sebastian Dröge <sebastian@centricular.com> Wed Aug 08 12:51:53 2018 +0200
tree db878b6bb443daf57a5cc7785b249936aea329bd
parent bcb4362919a8fc9998a4ca7378af17a11c9e8649

dvb: Fix string copy wiht strlen() argument

This is a new warning introduced by gcc 8

We already check just before that we have enough space, just do a regular
memcpy with the full string size.

camswclient.c:87:3: error: ‘strncpy’ specified bound depends on the length of the source argument [-Werror=stringop-overflow=]

sys/dvb/camswclient.c

diff --git a/sys/dvb/camswclient.c b/sys/dvb/camswclient.c
index 2020569..19774e5 100644
--- a/sys/dvb/camswclient.c
+++ b/sys/dvb/camswclient.c
@@ -84,7 +84,7 @@
   }
 
   addr.sun_family = AF_UNIX;
-  strncpy (addr.sun_path, sock_path, strlen (sock_path));
+  memcpy (addr.sun_path, sock_path, strlen (sock_path) + 1);
 
   GST_INFO ("connecting to softcam socket: %s", sock_path);
   if ((client->sock = socket (PF_UNIX, SOCK_STREAM, 0)) < 0) {