[DTV00830781] misc: fix coverity issues
[Description]
Fix CID
2548414
2548724
2548735
2548220
2548266
2280071
Calling risky function sprintf
Change-Id: Iea42a746b8912bce16122bc60dbe4c3f5b2eb628
CR-Id: DTV00830781
Signed-off-by: guo-jie.wang <guo-jie.wang@mediatek.com>
Feature: misc
diff --git a/common/wlan_lib.c b/common/wlan_lib.c
index 032b244..3501f33 100644
--- a/common/wlan_lib.c
+++ b/common/wlan_lib.c
@@ -6928,7 +6928,7 @@
for (i = 0; i < WLAN_CFG_SET_SW_CTRL_LEN_MAX; i++) {
kalMemZero(aucValue, WLAN_CFG_VALUE_LEN_MAX);
kalMemZero(aucKey, WLAN_CFG_VALUE_LEN_MAX);
- kalSprintf(aucKey, "SwCtrl%d", i);
+ kalSnprintf(aucKey, sizeof(aucKey), "SwCtrl%d", i);
/* get nothing */
if (wlanCfgGet(prAdapter, aucKey, aucValue, "", 0) != WLAN_STATUS_SUCCESS)
@@ -7021,7 +7021,7 @@
for (i = 0; i < WLAN_CFG_SET_DEBUG_LEVEL_LEN_MAX; i++) {
kalMemZero(aucValue, WLAN_CFG_VALUE_LEN_MAX);
kalMemZero(aucKey, WLAN_CFG_VALUE_LEN_MAX);
- kalSprintf(aucKey, "DbgLevel%d", i);
+ kalSnprintf(aucKey, sizeof(aucKey), "DbgLevel%d", i);
/* get nothing */
if (wlanCfgGet(prAdapter, aucKey, aucValue, "", 0) != WLAN_STATUS_SUCCESS)
diff --git a/mgmt/scan_fsm.c b/mgmt/scan_fsm.c
index 98e6907..57eb275 100644
--- a/mgmt/scan_fsm.c
+++ b/mgmt/scan_fsm.c
@@ -698,12 +698,15 @@
kalMemZero(g_aucScanChannelMDRDY, SCN_SCAN_DONE_PRINT_BUFFER_LENGTH);
u4PrintfIdx = 0;
}
- kalSprintf(g_aucScanChannelNum + u4PrintfIdx*7, "%7d",
- prScanInfo->aucChannelNum[u4ChCnt]);
- kalSprintf(g_aucScanChannelIdleTime + u4PrintfIdx*7, "%7d",
- prScanInfo->au2ChannelIdleTime[u4ChCnt]);
- kalSprintf(g_aucScanChannelMDRDY + u4PrintfIdx*7, "%7d",
- prScanInfo->aucChannelMDRDYCnt[u4ChCnt]);
+ kalSnprintf(g_aucScanChannelNum + u4PrintfIdx * 7,
+ sizeof(g_aucScanChannelNum) - u4PrintfIdx * 7,
+ "%7d", prScanInfo->aucChannelNum[u4ChCnt]);
+ kalSnprintf(g_aucScanChannelIdleTime + u4PrintfIdx * 7,
+ sizeof(g_aucScanChannelIdleTime) - u4PrintfIdx * 7,
+ "%7d", prScanInfo->au2ChannelIdleTime[u4ChCnt]);
+ kalSnprintf(g_aucScanChannelMDRDY + u4PrintfIdx * 7,
+ sizeof(g_aucScanChannelMDRDY) - u4PrintfIdx * 7,
+ "%7d", prScanInfo->aucChannelMDRDYCnt[u4ChCnt]);
u4PrintfIdx++;
}
diff --git a/nic/nic_cmd_event.c b/nic/nic_cmd_event.c
index c14d1c8..929d15e 100644
--- a/nic/nic_cmd_event.c
+++ b/nic/nic_cmd_event.c
@@ -1464,7 +1464,7 @@
*prIQAry = g_au4IQData;
/* sprintf(aucPath, "/pattern.txt"); // CSD's Pattern */
- sprintf(aucPath, "/tmp/dump_out_%05ld_WF%d.txt", (g_u2DumpIndex - 1), u4GetWf1);
+ snprintf(aucPath, sizeof(aucPath), "/tmp/dump_out_%05ld_WF%d.txt", (g_u2DumpIndex - 1), u4GetWf1);
if (kalCheckPath(aucPath) == -1)
snprintf(aucPath, sizeof(aucPath), "/data/dump_out_%05ld_WF%d.txt", (g_u2DumpIndex - 1), u4GetWf1);
@@ -1901,13 +1901,13 @@
ASSERT(prAdapter);
ASSERT(pucEventBuf);
- sprintf(aucPath, "/dump_%05ld.hex", g_u2DumpIndex);
+ snprintf(aucPath, sizeof(aucPath), "/dump_%05ld.hex", g_u2DumpIndex);
prEventDumpMem = (P_EVENT_DUMP_MEM_T) (pucEventBuf);
if (kalCheckPath(aucPath) == -1) {
kalMemSet(aucPath, 0x00, 256);
- sprintf(aucPath, "/data/dump_%05ld.hex", g_u2DumpIndex);
+ snprintf(aucPath, sizeof(aucPath), "/data/dump_%05ld.hex", g_u2DumpIndex);
}
if (prEventDumpMem->ucFragNum == 1) {
@@ -1918,10 +1918,10 @@
#if defined(LINUX)
/*if blbist mkdir undre /data/blbist, the dump files wouls put on it */
- sprintf(aucPath, "/dump_%05ld.hex", g_u2DumpIndex);
+ snprintf(aucPath, sizeof(aucPath), "/dump_%05ld.hex", g_u2DumpIndex);
if (kalCheckPath(aucPath) == -1) {
kalMemSet(aucPath, 0x00, 256);
- sprintf(aucPath, "/data/dump_%05ld.hex", g_u2DumpIndex);
+ snprintf(aucPath, sizeof(aucPath), "/data/dump_%05ld.hex", g_u2DumpIndex);
}
#else
kal_sprintf_ddk(aucPath, sizeof(aucPath),
@@ -1948,10 +1948,10 @@
g_bIcapEnable = FALSE;
g_bCaptureDone = TRUE;
- sprintf(aucPath_done, "/file_dump_done.txt");
+ snprintf(aucPath_done, sizeof(aucPath_done), "/file_dump_done.txt");
if (kalCheckPath(aucPath_done) == -1) {
kalMemSet(aucPath_done, 0x00, 256);
- sprintf(aucPath_done, "/data/file_dump_done.txt");
+ snprintf(aucPath_done, sizeof(aucPath_done), "/data/file_dump_done.txt");
}
DBGLOG(INIT, INFO, ": ==> gen done_file\n");
kalWriteToFile(aucPath_done, FALSE, aucPath_done, sizeof(aucPath_done));
@@ -2013,10 +2013,10 @@
g_u2DumpIndex = 0;
/*if blbist mkdir undre /data/blbist, the dump files wouls put on it */
- sprintf(aucPath, "/dump_%05ld.hex", g_u2DumpIndex);
+ snprintf(aucPath, sizeof(aucPath), "/dump_%05ld.hex", g_u2DumpIndex);
if (kalCheckPath(aucPath) == -1) {
kalMemSet(aucPath, 0x00, 256);
- sprintf(aucPath, "/data/dump_%05ld.hex", g_u2DumpIndex);
+ snprintf(aucPath, sizeof(aucPath), "/data/dump_%05ld.hex", g_u2DumpIndex);
} else
kalTrunkPath(aucPath);
