commit 074a57ce73a3d8f9543b6bb4595bf516140dcfac
author guo-jie.wang <guo-jie.wang@mediatek.com> Fri Nov 10 10:47:58 2017 +0800
committer Guo-Jie Wang <guo-jie.wang@mediatek.com> Fri Dec 01 13:00:01 2017 +0800
tree 15b714fbbb7735c1e3d9834c51d55b4bb956b3b7
parent 4882c0928ff55a9cfc00e3ca94f2ed5df6961fd2

[DTV00830781] misc: fix coverity issues

[Description]
Fix nic/*

Change-Id: I091d7ed7f14d6fa201459b27fe19b15a987bec6c
Feature: misc
CR-Id: DTV00830781
Signed-off-by: guo-jie.wang <guo-jie.wang@mediatek.com>
(cherry picked from commit 672250cbc1198ca21e9fac910cc26aba10496f8e)

nic/nic_tx.c

diff --git a/nic/nic_tx.c b/nic/nic_tx.c
index 87a9d4d..3f7f54c 100644
--- a/nic/nic_tx.c
+++ b/nic/nic_tx.c
@@ -3332,16 +3332,17 @@
 	UINT_32 u4StaPsBitmap;
 
 	u4StaPsBitmap = prAdapter->u4StaPsBitmap;
+	if (!u4StaPsBitmap)
+		return;
 
-	if (u4StaPsBitmap)
-		for (ucStaRecIndex = 0; ucStaRecIndex < CFG_STA_REC_NUM; ++ucStaRecIndex) {
-			if (QUEUE_IS_NOT_EMPTY(&prAdapter->rStaPsQueue[ucStaRecIndex])) {
-				nicTxDirectClearBssAbsentQ(prAdapter, ucStaRecIndex);
-				u4StaPsBitmap &= ~BIT(ucStaRecIndex);
-			}
-			if (u4StaPsBitmap == 0)
-				break;
+	for (ucStaRecIndex = 0; ucStaRecIndex < CFG_STA_REC_NUM; ++ucStaRecIndex) {
+		if (QUEUE_IS_NOT_EMPTY(&prAdapter->rStaPsQueue[ucStaRecIndex])) {
+			nicTxDirectClearStaPsQ(prAdapter, ucStaRecIndex);
+			u4StaPsBitmap &= ~BIT(ucStaRecIndex);
 		}
+		if (u4StaPsBitmap == 0)
+			break;
+	}
 }
 
 /*----------------------------------------------------------------------------*/
@@ -3367,6 +3368,7 @@
 		return;
 
 	prStaRec = cnmGetStaRecByIndex(prAdapter, ucStaRecIndex);
+	ASSERT(prStaRec);
 
 	QUEUE_CONCATENATE_QUEUES(&prAdapter->rStaPsQueue[ucStaRecIndex], prQue);
 	QUEUE_REMOVE_HEAD(&prAdapter->rStaPsQueue[ucStaRecIndex], prQueueEntry, P_QUE_ENTRY_T);