commit 16210831fe0ddd0c85709805c3456183c594a16c
author Aditya Pakki <pakki001@umn.edu> Wed Mar 20 10:27:11 2019 -0500
committer Alex Van Damme <atv@google.com> Tue Oct 29 13:46:20 2019 -0700
tree 95ebdb86045c64e976bc2617d840f88eb5506ddb
parent 5eb9c31fda4206014218c591a6cf5290d3ec2bc9

usb: usb251xb: fix to avoid potential NULL pointer dereference

of_match_device in usb251xb_probe can fail and returns a NULL pointer.
The patch avoids a potential NULL pointer dereference in this scenario.

Signed-off-by: Aditya Pakki <pakki001@umn.edu>
Reviewed-by: Richard Leitner <richard.leitner@skidata.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

drivers/usb/misc/usb251xb.c

diff --git a/drivers/usb/misc/usb251xb.c b/drivers/usb/misc/usb251xb.c
index 2c8e2ca..0468484 100644
--- a/drivers/usb/misc/usb251xb.c
+++ b/drivers/usb/misc/usb251xb.c
@@ -612,7 +612,7 @@
 							   dev);
 	int err;
 
-	if (np) {
+	if (np && of_id) {
 		err = usb251xb_get_ofdata(hub,
 					  (struct usb251xb_data *)of_id->data);
 		if (err) {