commit c72ec85879b37207a597cdbf4de8a7b6a6b3facf
author Nicolas Dufresne <nicolas.dufresne@collabora.com> Mon May 28 15:19:52 2018 -0400
committer Nicolas Dufresne <nicolas.dufresne@collabora.com> Thu Jun 07 15:40:36 2018 -0400
tree 0a364c7b6a1e1c7bfefad96301800f392ce06bd2
parent 61080b034eb3d7afadae53850a8c8826df76ba03

v4l2bufferpool: Drop truncated frames

Drop truncated frames regardless if they have the ERROR flag or not.
Truncated frame causes video frame map failure in many elements
including cluttersink, glupload etc.

sys/v4l2/gstv4l2bufferpool.c

diff --git a/sys/v4l2/gstv4l2bufferpool.c b/sys/v4l2/gstv4l2bufferpool.c
index 86d5c8b..bf0c76f 100644
--- a/sys/v4l2/gstv4l2bufferpool.c
+++ b/sys/v4l2/gstv4l2bufferpool.c
@@ -1719,6 +1719,10 @@
                 goto eos;
             }
 
+            if (GST_VIDEO_INFO_FORMAT (&pool->caps_info) !=
+                GST_VIDEO_FORMAT_ENCODED && size < pool->size)
+              goto buffer_truncated;
+
             num_queued = g_atomic_int_get (&pool->num_queued);
             GST_TRACE_OBJECT (pool, "Only %i buffer left in the capture queue.",
                 num_queued);
@@ -1948,6 +1952,14 @@
     *buf = NULL;
     return GST_V4L2_FLOW_CORRUPTED_BUFFER;
   }
+buffer_truncated:
+  {
+    GST_WARNING_OBJECT (pool,
+        "Dropping truncated buffer, this is likely a driver bug.");
+    gst_buffer_unref (*buf);
+    *buf = NULL;
+    return GST_V4L2_FLOW_CORRUPTED_BUFFER;
+  }
 eos:
   {
     GST_DEBUG_OBJECT (pool, "end of stream reached");