glcolorconvert: fix non-passthrough of RGB -> RGB
On i.MX we're always drawing EGLImages once since textures
are imported from dma-bufs that can't be re-exported.
When input and output are both RGB GStreamer tries to compile
a shader for the purpose, but the alpha channel mapping is
missing when
- input is same format as output
- that same format is only 3 chars
The channel map must always be 4 chars long, one char for
each of R G B A.
Bug: 161191133
Change-Id: Ib8d19fb30f09ef8ff24260014a05bb24e0a13b44
diff --git a/gst-libs/gst/gl/gstglcolorconvert.c b/gst-libs/gst/gl/gstglcolorconvert.c
index 232670a..8cc0768 100644
--- a/gst-libs/gst/gl/gstglcolorconvert.c
+++ b/gst-libs/gst/gl/gstglcolorconvert.c
@@ -1355,7 +1355,8 @@
int len;
gboolean discard_output = TRUE;
- if (g_ascii_strcasecmp (expected, wanted) == 0) {
+ /* Return value must have 4 chars (1 per each 4 channels). */
+ if (g_ascii_strcasecmp (expected, wanted) == 0 && strlen (expected) == 4) {
g_string_free (ret, TRUE);
return g_ascii_strdown (expected, -1);
}
