commit 5c92dea09585baf385111dad4e4e24e535a2bf0d
author Jonas Larsson <ljonas@google.com> Tue Oct 01 12:56:05 2019 -0700
committer Jonas Larsson <ljonas@google.com> Tue Oct 01 12:56:05 2019 -0700
tree f3c443e189f34a3d5ad874d2fe4c16bac1512c1e
parent a6bdc5914a18b433d506cf1d71b5ea2804488375

egl: Don't allocate texture memory for EGLImage

EGLImage that has its own storage (possibly in a dmabuf) still got
standard texture memory allocated for it. This doubles the memory
required per frame. Allocating the texture memory also isn't free,
it can take lots of time to allocate contigous memory for a 1080p
frame (over 25 ms), which stalls the pipeline causing frame drops.

Upstream candidate.

Change-Id: I78038d85992cd2742554be91f46c2010ac64595e

gst-libs/gst/gl/egl/gstglmemoryegl.c

diff --git a/gst-libs/gst/gl/egl/gstglmemoryegl.c b/gst-libs/gst/gl/egl/gstglmemoryegl.c
index 1f46114..8a63c18 100644
--- a/gst-libs/gst/gl/egl/gstglmemoryegl.c
+++ b/gst-libs/gst/gl/egl/gstglmemoryegl.c
@@ -182,11 +182,13 @@
     return FALSE;
   }
 
-  alloc_class = GST_GL_BASE_MEMORY_ALLOCATOR_CLASS (parent_class);
-  if (!alloc_class->create ((GstGLBaseMemory *) gl_mem, error))
-    return FALSE;
-
+  /* base will call TexImage2D to allocate storage. skip if we have an image
+   * or we'll use 2x GPU memory. */
   if (gl_mem->image == NULL) {
+    alloc_class = GST_GL_BASE_MEMORY_ALLOCATOR_CLASS (parent_class);
+    if (!alloc_class->create ((GstGLBaseMemory *) gl_mem, error))
+      return FALSE;
+
     gl_mem->image = gst_egl_image_from_texture (context,
         (GstGLMemory *) gl_mem, NULL);
 
@@ -196,6 +198,15 @@
       return FALSE;
     }
   } else {
+    gl->GenTextures (1, &gl_mem->mem.tex_id);
+    gl->BindTexture (GL_TEXTURE_2D, gl_mem->mem.tex_id);
+    gl->TexParameteri (GL_TEXTURE_2D, GL_TEXTURE_MAG_FILTER, GL_LINEAR);
+    gl->TexParameteri (GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, GL_LINEAR);
+    gl->TexParameteri (GL_TEXTURE_2D, GL_TEXTURE_WRAP_S, GL_CLAMP_TO_EDGE);
+    gl->TexParameteri (GL_TEXTURE_2D, GL_TEXTURE_WRAP_T, GL_CLAMP_TO_EDGE);
+    GST_TRACE ("Generated texture id %u for EGLImage %p", gl_mem->mem.tex_id,
+        gl_mem->image);
+
     gl->ActiveTexture (GL_TEXTURE0 + gl_mem->mem.plane);
     gl->BindTexture (GL_TEXTURE_2D, gl_mem->mem.tex_id);
     gl->EGLImageTargetTexture2D (GL_TEXTURE_2D,