commit 8a7d6b732a74ccbff1ced447b31b297d53560e44
author Jonas Larsson <ljonas@google.com> Tue Oct 30 14:36:06 2018 -0700
committer Alex Van Damme <atv@google.com> Mon Jun 17 14:20:16 2019 -0700
tree d7cae7526700b2c94a6ba89614bc7cfe67f7ffcd
parent 0191521ba226904e4b2f84c38e5f6ae75169a18a

kmssink: fix bad property memory management

When the driver-name property is read it incorrectly
transfers ownership of the underlying string to the
reader of the property, causing crashes.

This prevented using GST_DEBUG_DUMP_DOT_DIR to dump
pipeline graphs containing kmssink, as the dumping
process always reads all properties.

Change-Id: I5432ca1e3eca793153fdab93909a39bbc1698720

sys/kms/gstkmssink.c

diff --git a/sys/kms/gstkmssink.c b/sys/kms/gstkmssink.c
index 453b00c..e38d638 100644
--- a/sys/kms/gstkmssink.c
+++ b/sys/kms/gstkmssink.c
@@ -2172,7 +2172,7 @@
 
   switch (prop_id) {
     case PROP_DRIVER_NAME:
-      g_value_take_string (value, sink->devname);
+      g_value_set_string (value, sink->devname);
       break;
     case PROP_BUS_ID:
       g_value_take_string (value, sink->bus_id);