commit 89564618f472a1bf3c13ef6f5e519dbabbe90570
author Szymon Janc <szymon.janc@codecoup.pl> Thu Mar 22 21:07:55 2018 +0100
committer Luiz Augusto von Dentz <luiz.von.dentz@intel.com> Fri Mar 23 13:19:06 2018 +0200
tree 4535ffdb723e15c570cc73622dc28c9d0e63804d
parent 806ba442da966a253245f2719f36c6fc1b83be9c

gatt: Fail to register service with invalid Includes property

This is optional property but if it is present it must be of
proper type.

src/gatt-database.c

diff --git a/src/gatt-database.c b/src/gatt-database.c
index a22fc3b..19f03c5 100644
--- a/src/gatt-database.c
+++ b/src/gatt-database.c
@@ -1676,6 +1676,7 @@
 	DBusMessageIter array;
 	char *obj;
 
+	/* Includes property is optional */
 	if (!g_dbus_proxy_get_property(proxy, "Includes", &iter))
 		return true;
 
@@ -2682,8 +2683,10 @@
 		return false;
 	}
 
-	if (!parse_includes(service->proxy, service))
+	if (!parse_includes(service->proxy, service)) {
 		error("Failed to read \"Includes\" property of service");
+		return false;
+	}
 
 	service->attrib = gatt_db_add_service(service->app->database->db, &uuid,
 						primary, service->attr_cnt);