commit 5aa0dd42f7b45b5ef2bceb8510aeb2a892866abf
author ERAMOTO Masaya <eramoto.masaya@jp.fujitsu.com> Mon Mar 19 13:46:05 2018 +0900
committer Luiz Augusto von Dentz <luiz.von.dentz@intel.com> Mon Mar 19 07:45:20 2018 +0200
tree 4f8b8715cb8929f8c269e5b9d1da9e214168113d
parent 1c1f807c304a77ae4965f00ccee04fdbe7415d5e

shared/shell: Return NULL if generator error occur

Explicitly returns NULL if asprintf() fails, since the asprintf(3)
man-page says that the contents of the first argument are undefined if
any error occurs.

src/shared/shell.c

diff --git a/src/shared/shell.c b/src/shared/shell.c
index 0a05b52..7417e7a 100644
--- a/src/shared/shell.c
+++ b/src/shared/shell.c
@@ -643,8 +643,13 @@
 	}
 
 	cmd = find_cmd(text + strlen(menu->name) + 1, menu->entries, &index);
-	if (cmd)
-		asprintf(&cmd, "%s.%s", menu->name, cmd);
+	if (cmd) {
+		int err;
+
+		err = asprintf(&cmd, "%s.%s", menu->name, cmd);
+		if (err < 0)
+			return NULL;
+	}
 
 	return cmd;
 }