commit 0c2900e54e80776317f2da0b2d60ad6a142dbae3
author Luiz Augusto von Dentz <luiz.von.dentz@intel.com> Fri Feb 23 14:29:22 2018 +0200
committer Luiz Augusto von Dentz <luiz.von.dentz@intel.com> Wed Feb 28 16:17:13 2018 +0200
tree 86852d26bc5a73679e9c58deecf78bcdda01facb
parent deae158e2bac8971d1dd5573f0aa4af968b21e35

shared/shell: Disable readline while in noninteractive mode

User shall not be able to interact with the shell while in
noninteractive mode.

src/shared/shell.c

diff --git a/src/shared/shell.c b/src/shared/shell.c
index b4e6436..f6b77c1 100644
--- a/src/shared/shell.c
+++ b/src/shared/shell.c
@@ -393,6 +393,13 @@
 	if (!data.input)
 		return;
 
+	if (data.mode) {
+		va_start(args, fmt);
+		vprintf(fmt, args);
+		va_end(args);
+		return;
+	}
+
 	save_input = !RL_ISSTATE(RL_STATE_DONE);
 
 	if (save_input) {
@@ -695,7 +702,7 @@
 
 	switch (si.ssi_signo) {
 	case SIGINT:
-		if (data.input) {
+		if (data.input && !data.mode) {
 			rl_replace_line("", 0);
 			rl_crlf();
 			rl_on_new_line();
@@ -713,8 +720,10 @@
 		/* fall through */
 	case SIGTERM:
 		if (!terminated) {
-			rl_replace_line("", 0);
-			rl_crlf();
+			if (!data.mode) {
+				rl_replace_line("", 0);
+				rl_crlf();
+			}
 			mainloop_quit();
 		}
 
@@ -757,6 +766,9 @@
 
 static void rl_init(void)
 {
+	if (data.mode)
+		return;
+
 	setlinebuf(stdout);
 	rl_attempted_completion_function = shell_completion;
 
@@ -854,6 +866,9 @@
 
 static void rl_cleanup(void)
 {
+	if (data.mode)
+		return;
+
 	rl_message("");
 	rl_callback_handler_remove();
 }
@@ -965,7 +980,9 @@
 
 	io = io_new(fd);
 
-	io_set_read_handler(io, input_read, NULL, NULL);
+	if (!data.mode)
+		io_set_read_handler(io, input_read, NULL, NULL);
+
 	io_set_disconnect_handler(io, io_hup, NULL, NULL);
 
 	data.input = io;