commit e923e5ef62eee41c61953a6afc5ed1303dbf41ba
author Treehugger Robot <treehugger-gerrit@google.com> Wed Apr 24 22:38:31 2019 +0000
committer Gerrit Code Review <noreply-gerritcodereview@google.com> Wed Apr 24 22:38:31 2019 +0000
tree b76450f9eccb5c66ad8b1ad54b8589790a346e53
parent 4d89dc0f546fd7bc3fe659257f32409ec8e40bf3
parent 499601b94fa36759648542039d3df25e901ebb77

Merge "adb: fix double close in wait-for-*."

adb/services.cpp

diff --git a/adb/services.cpp b/adb/services.cpp
index 335ffc4..46cab6e 100644
--- a/adb/services.cpp
+++ b/adb/services.cpp
@@ -100,7 +100,7 @@
     ConnectionState state;
 };
 
-static void wait_for_state(int fd, state_info* sinfo) {
+static void wait_for_state(unique_fd fd, state_info* sinfo) {
     D("wait_for_state %d", sinfo->state);
 
     while (true) {
@@ -122,7 +122,7 @@
         }
 
         if (!is_ambiguous) {
-            adb_pollfd pfd = {.fd = fd, .events = POLLIN};
+            adb_pollfd pfd = {.fd = fd.get(), .events = POLLIN};
             int rc = adb_poll(&pfd, 1, 100);
             if (rc < 0) {
                 SendFail(fd, error);
@@ -140,7 +140,6 @@
         }
     }
 
-    adb_close(fd);
     D("wait_for_state is done");
 }
 
@@ -241,9 +240,8 @@
             return nullptr;
         }
 
-        unique_fd fd = create_service_thread("wait", [sinfo](int fd) {
-            wait_for_state(fd, sinfo.get());
-        });
+        unique_fd fd = create_service_thread(
+                "wait", [sinfo](unique_fd fd) { wait_for_state(std::move(fd), sinfo.get()); });
         return create_local_socket(std::move(fd));
     } else if (ConsumePrefix(&name, "connect:")) {
         std::string host(name);