tree a5f5485a80cdd7b626a36cee992551d768ba4ff1
parent 79988f34416f154dfbeca7cc30fe21eee35c5368
author Mattijs Korpershoek <mkorpershoek@baylibre.com> 1575315694 -0800
committer Mattijs Korpershoek <mkorpershoek@baylibre.com> 1575328562 -0800

cmd: aprop: fix double free() in aprop_load()

In case the partition file exist but we are unable to read it, we have
the following crash:
  MMC read: dev # 0, block # 5120, count 16320 ... 16320 blocks read: OK
  fs_devread read outside partition 15498713464
  Error: file /property/persistent_properties read failed (-1)
  "Synchronous Abort" handler, esr 0x96000044
  elr: 000000004c0157c4 lr : 000000004c00ff68 (reloc)
  elr: 000000007ffa97c4 lr : 000000007ffa3f68
  x0 : 000000007fb9db40 x1 : 000000007fb94900
  x2 : 000000676d697464 x3 : 000000007ffdca88
  x4 : 000000007fb9db50 x5 : 000000007ffdc9c8
  x6 : 000000000000000c x7 : 000000007ffdca88
  x8 : 0000000000000000 x9 : 0000000000000002
  x10: 000000000000000d x11: 0000000000000006
  x12: 000000000001869f x13: 0000000000000013
  x14: 000000000000000c x15: 00000000fffffffe
  x16: 0000000000001080 x17: 0000000000000000
  x18: 000000007fb92df0 x19: 000000007fb90e60

We have a double free in that error path. Fix it by removing
one free() statement.

Bug: https://baylibre.atlassian.net/browse/RITA-38
Signed-off-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>