commit 83e1bee3f10c351076e3534ee9bb084519ebb883
author Sebastian Dröge <sebastian@centricular.com> Tue Sep 25 16:56:07 2018 +0300
committer Sebastian Dröge <sebastian@centricular.com> Thu Sep 27 22:33:31 2018 +0300
tree ab7196c51157af94fb6f9c3c908c0ec2293f455f
parent 24c20d4ced940c64f27a62bc109e7b7360bc6b05

glcolorconvert: Don't copy overlay composition meta over to NULL outbufs

gst-libs/gst/gl/gstglcolorconvert.c

diff --git a/gst-libs/gst/gl/gstglcolorconvert.c b/gst-libs/gst/gl/gstglcolorconvert.c
index 43d2caf..60d9653 100644
--- a/gst-libs/gst/gl/gstglcolorconvert.c
+++ b/gst-libs/gst/gl/gstglcolorconvert.c
@@ -2324,7 +2324,6 @@
   struct ConvertInfo *c_info = &convert->priv->convert_info;
   gboolean res = TRUE;
   gint views, v;
-  GstVideoOverlayCompositionMeta *composition_meta;
   GstGLSyncMeta *sync_meta;
   GstFlowReturn ret;
 
@@ -2440,19 +2439,20 @@
   }
 
   if (convert->outbuf) {
+    GstVideoOverlayCompositionMeta *composition_meta;
     GstGLSyncMeta *sync_meta =
         gst_buffer_add_gl_sync_meta (convert->context, convert->outbuf);
 
     if (sync_meta)
       gst_gl_sync_meta_set_sync_point (sync_meta, convert->context);
-  }
 
-  composition_meta =
-      gst_buffer_get_video_overlay_composition_meta (convert->inbuf);
-  if (composition_meta) {
-    GST_DEBUG ("found video overlay composition meta, applying on output.");
-    gst_buffer_add_video_overlay_composition_meta
-        (convert->outbuf, composition_meta->overlay);
+    composition_meta =
+        gst_buffer_get_video_overlay_composition_meta (convert->inbuf);
+    if (composition_meta) {
+      GST_DEBUG ("found video overlay composition meta, applying on output.");
+      gst_buffer_add_video_overlay_composition_meta
+          (convert->outbuf, composition_meta->overlay);
+    }
   }
 
   convert->priv->result = res;