commit 6e30040809c9ebc47f42a8c578ce0a3ed7b84855
author Matthew Waters <matthew@centricular.com> Wed Sep 26 13:22:14 2018 +1000
committer Sebastian Dröge <sebastian@centricular.com> Thu Sep 27 22:33:49 2018 +0300
tree 2e4a644ea1bc683bc3b410029d44c831fcb7e675
parent 54e21b7bc279d234c0cb700f7d1f3baefb3ccadb

glviewconvert: wait and set the gl sync meta on buffers

This may be a cause of out-of-place frames when transforming multiview
buffers.

gst-libs/gst/gl/gstglviewconvert.c

diff --git a/gst-libs/gst/gl/gstglviewconvert.c b/gst-libs/gst/gl/gstglviewconvert.c
index d56714a..9c0dc44 100644
--- a/gst-libs/gst/gl/gstglviewconvert.c
+++ b/gst-libs/gst/gl/gstglviewconvert.c
@@ -37,14 +37,8 @@
 
 #include <gst/video/gstvideoaffinetransformationmeta.h>
 
-#include "gstglcontext.h"
-#include "gstglframebuffer.h"
-#include "gstglmemory.h"
-#include "gstglshader.h"
-#include "gstglshaderstrings.h"
-#include "gstglsl.h"
+#include "gl.h"
 #include "gstglsl_private.h"
-#include "gstglslstage.h"
 #include "gstglutils_private.h"
 
 #define USING_OPENGL(context) (gst_gl_context_check_gl_version (context, GST_GL_API_OPENGL, 1, 0))
@@ -2017,6 +2011,7 @@
   gint in_views, out_views;
   GstVideoMultiviewMode in_mode;
   GstVideoMultiviewMode out_mode;
+  GstGLSyncMeta *sync_meta;
 
   out_width = GST_VIDEO_INFO_WIDTH (&viewconvert->out_info);
   out_height = GST_VIDEO_INFO_HEIGHT (&viewconvert->out_info);
@@ -2149,6 +2144,18 @@
   }
   priv->n_out_tex = out_views;
 
+  if (priv->primary_in) {
+    if ((sync_meta = gst_buffer_get_gl_sync_meta (priv->primary_in))) {
+      gst_gl_sync_meta_wait (sync_meta, context);
+    }
+  }
+
+  if (priv->auxilliary_in) {
+    if ((sync_meta = gst_buffer_get_gl_sync_meta (priv->auxilliary_in))) {
+      gst_gl_sync_meta_wait (sync_meta, context);
+    }
+  }
+
   GST_LOG_OBJECT (viewconvert, "multiview splitting to textures:%p,%p,%p,%p "
       "dimensions:%ux%u, from textures:%p,%p,%p,%p dimensions:%ux%u",
       priv->out_tex[0], priv->out_tex[1],
@@ -2200,6 +2207,17 @@
     gst_buffer_replace (&priv->auxilliary_out, NULL);
   }
 
+  if (priv->primary_out) {
+    if ((sync_meta = gst_buffer_add_gl_sync_meta (context, priv->primary_out)))
+      gst_gl_sync_meta_set_sync_point (sync_meta, context);
+  }
+
+  if (priv->auxilliary_out) {
+    if ((sync_meta =
+            gst_buffer_add_gl_sync_meta (context, priv->auxilliary_out)))
+      gst_gl_sync_meta_set_sync_point (sync_meta, context);
+  }
+
   priv->result = res;
   return;
 }