commit e9909958e23ead871f5797d6e2b6cc2dcb477783
author Jun Xie <jun.xie@samsung.com> Tue Feb 27 10:51:07 2018 +0800
committer Sebastian Dröge <sebastian@centricular.com> Sat Apr 28 10:46:39 2018 +0300
tree 940bae93a834ef9f1d40476b59ee4814789f4a13
parent c187a097c81b7628e129663c6d88fcdc09805b4f

curlhttpsrc: deadlock in multi-instance scenario

Fixed queue iterator issue and set context state to
GSTCURL_MULTI_LOOP_STATE_RUNNING in case other
instance are in running state.

https://bugzilla.gnome.org/show_bug.cgi?id=793863

ext/curl/gstcurlhttpsrc.c

diff --git a/ext/curl/gstcurlhttpsrc.c b/ext/curl/gstcurlhttpsrc.c
index a47508e..e60ccf5 100644
--- a/ext/curl/gstcurlhttpsrc.c
+++ b/ext/curl/gstcurlhttpsrc.c
@@ -1668,8 +1668,10 @@
         g_mutex_unlock (&qelement->p->buffer_mutex);
         gst_curl_http_src_remove_queue_item (&context->queue, qelement->p);
       }
+      qelement = qelement->next;
     }
     context->request_removal_element = NULL;
+    context->state = GSTCURL_MULTI_LOOP_STATE_RUNNING;
     g_mutex_unlock (&context->mutex);
   } else {
     GSTCURL_WARNING_PRINT ("Curl Loop State was invalid or unsupported");