commit ddcc1c64429904e08ea513b1431690e8e473f7d2
author Tim-Philipp Müller <tim@centricular.com> Tue May 10 09:40:38 2016 +0100
committer Tim-Philipp Müller <tim@centricular.com> Tue May 10 09:40:38 2016 +0100
tree 2b8c4c9234e48fc10f12de7524f9dc82b957ef7b
parent 8d128f8bf5ceb9a7a74e8153e0434596989698f5

decklinkvideosrc: fix use-after-free in error code path

sys/decklink/gstdecklinkvideosrc.cpp

diff --git a/sys/decklink/gstdecklinkvideosrc.cpp b/sys/decklink/gstdecklinkvideosrc.cpp
index 8854c1b..a795f20 100644
--- a/sys/decklink/gstdecklinkvideosrc.cpp
+++ b/sys/decklink/gstdecklinkvideosrc.cpp
@@ -567,10 +567,10 @@
       self->caps_mode = f->mode;
     } else {
       g_mutex_unlock (&self->lock);
-      capture_frame_free (f);
       GST_ELEMENT_ERROR (self, CORE, NEGOTIATION,
           ("Invalid mode in captured frame"),
           ("Mode set to %d but captured %d", self->caps_mode, f->mode));
+      capture_frame_free (f);
       return GST_FLOW_NOT_NEGOTIATED;
     }
   }
@@ -582,10 +582,10 @@
       self->caps_format = f->format;
     } else {
       g_mutex_unlock (&self->lock);
-      capture_frame_free (f);
       GST_ELEMENT_ERROR (self, CORE, NEGOTIATION,
           ("Invalid pixel format in captured frame"),
           ("Format set to %d but captured %d", self->caps_format, f->format));
+      capture_frame_free (f);
       return GST_FLOW_NOT_NEGOTIATED;
     }
   }