commit 73fe643f2375d73ee6b08248558a06c679a6e25c
author Jan Schmidt <jan@centricular.com> Sun Jul 01 10:44:45 2018 +1000
committer Jan Schmidt <jan@centricular.com> Mon Jul 02 18:13:45 2018 +1000
tree 4fffc63cd6ca935d5bd838aeda8908715dcd6045
parent 798a5d42ab09262af101dbd58c9eb57d59b4736d

webrtc: Explicitly initialise mutex and condition

Fixes random crashes when an allocated webrtcbin isn't
given fresh 0-filled memory in its allocation. It works
mostly because GMutex and GCond are automatically initialised
in that case.

ext/webrtc/gstwebrtcbin.c

diff --git a/ext/webrtc/gstwebrtcbin.c b/ext/webrtc/gstwebrtcbin.c
index 233cb99..87ad7bb 100644
--- a/ext/webrtc/gstwebrtcbin.c
+++ b/ext/webrtc/gstwebrtcbin.c
@@ -4016,6 +4016,9 @@
     gst_structure_free (webrtc->priv->stats);
   webrtc->priv->stats = NULL;
 
+  g_mutex_clear (PC_GET_LOCK (webrtc));
+  g_cond_clear (PC_GET_COND (webrtc));
+
   G_OBJECT_CLASS (parent_class)->finalize (object);
 }
 
@@ -4337,6 +4340,8 @@
   webrtc->priv =
       G_TYPE_INSTANCE_GET_PRIVATE ((webrtc), GST_TYPE_WEBRTC_BIN,
       GstWebRTCBinPrivate);
+  g_mutex_init (PC_GET_LOCK (webrtc));
+  g_cond_init (PC_GET_COND (webrtc));
 
   _start_thread (webrtc);