commit 6184527532617cbc082e26dffa94108f958e1b21
author Christoph Reiter <reiter.christoph@gmail.com> Wed May 23 21:10:00 2018 +0200
committer Nirbheek Chauhan <nirbheek@centricular.com> Fri May 25 19:08:18 2018 +0530
tree b201f66f66893ec0e1d799edefd743d0ddfef425
parent 2c01338e917f2acb9043f03cdd40501ff4c1421b

wasapisink: fix missing unlock in case IAudioClient_Start fails

https://bugzilla.gnome.org/show_bug.cgi?id=796354

sys/wasapi/gstwasapisink.c

diff --git a/sys/wasapi/gstwasapisink.c b/sys/wasapi/gstwasapisink.c
index fc5a32f..7bff5d1 100644
--- a/sys/wasapi/gstwasapisink.c
+++ b/sys/wasapi/gstwasapisink.c
@@ -611,7 +611,8 @@
   GST_OBJECT_LOCK (self);
   if (self->client_needs_restart) {
     hr = IAudioClient_Start (self->client);
-    HR_FAILED_AND (hr, IAudioClient::Start, length = 0; goto beach);
+    HR_FAILED_AND (hr, IAudioClient::Start,
+      GST_OBJECT_UNLOCK (self); length = 0; goto beach);
     self->client_needs_restart = FALSE;
   }
   GST_OBJECT_UNLOCK (self);