commit fb745a8848d5d3da08410ee8da27498209ca681c
author Peter Nordström <pnordstrom@google.com> Wed Apr 03 16:27:16 2019 -0700
committer Alex Van Damme <atv@google.com> Wed Sep 09 12:15:29 2020 -0700
tree 0d072248b878b1fd61191b1c30a2c971df2ce02c
parent fae4ce8e0b23738880b083afc2db81f6bc42577f

ov5645: Fix incorrect behavior of ov5645_set_regs

The sysfs functionality of setting registers for the OV5645 camera
was broken. This is purely for development and debugging functionality
so does not fix any "real" bugs.

Change-Id: I991e1319aaf58cda66bdeac55f035f72c16b9441

drivers/media/platform/mxc/capture/ov5645_mipi_v2.c

diff --git a/drivers/media/platform/mxc/capture/ov5645_mipi_v2.c b/drivers/media/platform/mxc/capture/ov5645_mipi_v2.c
index 6c47f66..e1e4475 100644
--- a/drivers/media/platform/mxc/capture/ov5645_mipi_v2.c
+++ b/drivers/media/platform/mxc/capture/ov5645_mipi_v2.c
@@ -3432,7 +3432,7 @@ static int ov5645_set_regs(const char *buffer, struct kernel_param *kp)
 	if (in_string == NULL)
 		return 0;
 
-	while (true) {
+	while (in_string != NULL) {
 		reg = strsep(&in_string, ",");
 		cnt = sscanf(reg, "%x", &reg_addr);
 		if (cnt != 1)