)]}'
{
  "commit": "b64d70825abbf706bbe80be1b11b09514b71f45e",
  "tree": "2e44dc590b4cbfb198294c85fe59a5023083bfb6",
  "parents": [
    "e482179d547ff250cab487859b6fc91995bbdbb5"
  ],
  "author": {
    "name": "Jean Delvare",
    "email": "khali@linux-fr.org",
    "time": "Wed Nov 28 16:21:35 2007 -0800"
  },
  "committer": {
    "name": "Linus Torvalds",
    "email": "torvalds@woody.linux-foundation.org",
    "time": "Thu Nov 29 09:24:52 2007 -0800"
  },
  "message": "fb_ddc: fix DDC lines quirk\n\nThe code in fb_ddc_read() is said to be based on the implementation of the\nradeon driver:\nhttp://git.kernel.org/?p\u003dlinux/kernel/git/torvalds/linux-2.6.git;a\u003dcommitdiff;h\u003dfc5891c8a3ba284f13994d7bc1f1bfa8283982de\n\nHowever, comparing the old radeon driver code with the new fb_ddc code\nreveals some differences.  Most notably, the I2C bus lines are held at the\nend of the function, while the original code was releasing them (as the\ncomment above correctly says.)\n\nThere are a few other differences, which appear to be responsible for read\nfailures on my system.  While tracing low-level I2C code in i2c-algo-bit, I\nnoticed that the initial attempt to read the EDID always failed.  It takes\none retry for the read to succeed.  As we are about to remove this\nautomatic retry property from i2c-algo-bit, reading the EDID would really\nfail.\n\nAs a summary, the I2C lines quirk which is supposedly needed to read EDID\non some older monitors is currently breaking the (first) read on all other\nmonitors (and might not even work with older ones - did anyone try since\nOctober 2006?)\n\nAfter applying the patch below, which makes the code in fb_ddc_read()\nreally similar to what the radeon driver used to have, the first EDID read\nsucceeds again.\n\nOn top of that, as it appears that this code has been broken for one year\nnow and nobody seems to have complained, I\u0027m curious if it makes sense to\nkeep this quirk in place.  It makes the code more complex and slower just\nfor the sake of monitors which I guess nobody uses anymore.  Can\u0027t we just\nget rid of it?\n\nSigned-off-by: Jean Delvare \u003ckhali@linux-fr.org\u003e\nAcked-by: Benjamin Herrenschmidt \u003cbenh@kernel.crashing.org\u003e\nTested-by: Roger Leigh \u003crleigh@whinlatter.ukfsn.org\u003e\nTested-by: Michael Buesch \u003cmb@bu3sch.de\u003e\nCc: \"Antonino A. Daplas\" \u003cadaplas@pol.net\u003e\nCc: \u003cstable@kernel.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "f836137a0edac366b1d814c4230d7517e88a6b9d",
      "old_mode": 33188,
      "old_path": "drivers/video/fb_ddc.c",
      "new_id": "a0df63289b5f83ed9007be92df25c9c5f7065b4c",
      "new_mode": 33188,
      "new_path": "drivers/video/fb_ddc.c"
    }
  ]
}