tree b8f65dc4e1b5b6cd9bb144698c7007b7483a7c80
parent 3f683d6175748ef9daf4698d9ef5a488dd037063
author Herbert Xu <herbert@gondor.apana.org.au> 1234960435 +0800
committer Herbert Xu <herbert@gondor.apana.org.au> 1234963206 +0800

crypto: skcipher - Avoid infinite loop when cipher fails selftest

When an skcipher constructed through crypto_givcipher_default fails
its selftest, we'll loop forever trying to construct new skcipher
objects but failing because it already exists.

The crux of the issue is that once a givcipher fails the selftest,
we'll ignore it on the next run through crypto_skcipher_lookup and
attempt to construct a new givcipher.

We should instead return an error to the caller if we find a
givcipher that has failed the test.

Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>