commit 77418921649427577143667fcf00ccb8a809762a
author Thomas Meyer <thomas@m3y3r.de> Sat Jun 01 11:40:02 2013 +0200
committer Tony Luck <tony.luck@intel.com> Mon Jun 03 15:37:02 2013 -0700
tree 330bcc094a773d292e93f4b5b60ed9ced7cb1524
parent d683b96b072dc4680fc74964eca77e6a23d1fa6e

efi, pstore: Cocci spatch "memdup.spatch"

Change a kmalloc() + memcpy() pair for a single kmemdup() call.

Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
Acked-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Tony Luck <tony.luck@intel.com>

drivers/firmware/efi/efi-pstore.c

diff --git a/drivers/firmware/efi/efi-pstore.c b/drivers/firmware/efi/efi-pstore.c
index 202d2c8..c692bb6 100644
--- a/drivers/firmware/efi/efi-pstore.c
+++ b/drivers/firmware/efi/efi-pstore.c
@@ -79,10 +79,9 @@
 			   &entry->var.DataSize, entry->var.Data);
 	size = entry->var.DataSize;
 
-	*cb_data->buf = kmalloc(size, GFP_KERNEL);
+	*cb_data->buf = kmemdup(entry->var.Data, size, GFP_KERNEL);
 	if (*cb_data->buf == NULL)
 		return -ENOMEM;
-	memcpy(*cb_data->buf, entry->var.Data, size);
 	return size;
 }