)]}'
{
  "commit": "35d9b0c906ad92d32a0b8db5daa6fabfcc2f068d",
  "tree": "d9cdc72902f327ff377dd8bedfaeb0a8eead24a5",
  "parents": [
    "75c1c82566f23dd539fb7ccbf57a1caa7ba82628"
  ],
  "author": {
    "name": "Eric Dumazet",
    "email": "eric.dumazet@gmail.com",
    "time": "Sun Dec 05 02:03:26 2010 +0000"
  },
  "committer": {
    "name": "David S. Miller",
    "email": "davem@davemloft.net",
    "time": "Wed Dec 08 09:58:44 2010 -0800"
  },
  "message": "llc: fix a device refcount imbalance\n\nLe dimanche 05 décembre 2010 à 12:23 +0100, Eric Dumazet a écrit :\n\u003e Le dimanche 05 décembre 2010 à 09:19 +0100, Eric Dumazet a écrit :\n\u003e\n\u003e \u003e Hmm..\n\u003e \u003e\n\u003e \u003e If somebody can explain why RTNL is held in arp_ioctl() (and therefore\n\u003e \u003e in arp_req_delete()), we might first remove RTNL use in arp_ioctl() so\n\u003e \u003e that your patch can be applied.\n\u003e \u003e\n\u003e \u003e Right now it is not good, because RTNL wont be necessarly held when you\n\u003e \u003e are going to call arp_invalidate() ?\n\u003e\n\u003e While doing this analysis, I found a refcount bug in llc, I\u0027ll send a\n\u003e patch for net-2.6\n\nOh well, of course I must first fix the bug in net-2.6, and wait David\npull the fix in net-next-2.6 before sending this rcu conversion.\n\nNote: this patch should be sent to stable teams (2.6.34 and up)\n\n[PATCH net-2.6] llc: fix a device refcount imbalance\n\ncommit abf9d537fea225 (llc: add support for SO_BINDTODEVICE) added one\nrefcount imbalance in llc_ui_bind(), because dev_getbyhwaddr() doesnt\ntake a reference on device, while dev_get_by_index() does.\n\nFix this using RCU locking. And since an RCU conversion will be done for\n2.6.38 for dev_getbyhwaddr(), put the rcu_read_lock/unlock exactly at\ntheir final place.\n\nSigned-off-by: Eric Dumazet \u003ceric.dumazet@gmail.com\u003e\nCc: stable@kernel.org\nCc: Octavian Purdila \u003copurdila@ixiacom.com\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "582612998211d24aa8d4aea919eed1ba1e994db3",
      "old_mode": 33188,
      "old_path": "net/llc/af_llc.c",
      "new_id": "e35dbe55f5201c7a8b4b61ffe382766e4abadcb8",
      "new_mode": 33188,
      "new_path": "net/llc/af_llc.c"
    }
  ]
}