tree 717ac1144e8724117ea8d66896c0d36709584c46
parent 2ba1fe7a06d3624f9a7586d672b55f08f7c670f3
author Nicolas Boichat <drinkcat@chromium.org> 1453124100 +0800
committer Takashi Iwai <tiwai@suse.de> 1453124340 +0100

ALSA: pcm: Fix snd_pcm_hw_params struct copy in compat mode

This reverts one hunk of
commit ef44a1ec6eee ("ALSA: sound/core: use memdup_user()"), which
replaced a number of kmalloc followed by memcpy with memdup calls.

In this case, we are copying from a struct snd_pcm_hw_params32 to
a struct snd_pcm_hw_params, but the latter is 4 bytes longer than
the 32-bit version, so we need to separate kmalloc and copy calls.

This actually leads to an out-of-bounds memory access later on
in sound/soc/soc-pcm.c:soc_pcm_hw_params() (detected using KASan).

Fixes: ef44a1ec6eee ('ALSA: sound/core: use memdup_user()')
Signed-off-by: Nicolas Boichat <drinkcat@chromium.org>
Cc: <stable@vger.kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>