tree f151d3896bf373e314176131f4fb7f34c4f65ee6
parent b3cee7155a664708df20367ef34b25faa1b95acc
author Wim Taymans <wim.taymans@collabora.co.uk> 1339422118 +0200
committer Wim Taymans <wim.taymans@collabora.co.uk> 1339422118 +0200

bin: reorganize _remove_func to avoid races

Make the gst_bin_remove_func more like the add_func. Check if the element we try
to remove from the bin has the bin as the parent and set the parent flag to NULL
immediately, this allows us to avoid concurrent remove operations without using
the UNPARENTING element flag. After we unparented the element from the bin, we
update the bin state and remove the element from the list. Finally we unlink
all the pads.

This avoids a race condition where the element could still claim to have the
bin as the parent while the bin didn't have a pointer to the element anymore.

Fixes https://bugzilla.gnome.org/show_bug.cgi?id=647759