commit 4d6c7ccd08ffc8edbdfa3a7351cf8c0d99c681e9
author Nirbheek Chauhan <nirbheek@centricular.com> Fri Jan 15 00:25:05 2016 +0530
committer Tim-Philipp Müller <tim@centricular.com> Thu Jan 14 22:07:51 2016 +0000
tree ed77715c512f4c73a867816139482e00b8b8ced8
parent f875bec51e0822889043b8609342320f4e735380

GstDeviceMonitor: Don't remove unmatched class filters

If no providers for a particular class could be found, then removing unmatched
filters would cause all devices to be returned instead which is not at all what
the user intended. We still return 0 for unmatched filters.

gst/gstdevicemonitor.c

diff --git a/gst/gstdevicemonitor.c b/gst/gstdevicemonitor.c
index a9eda0a..4e6ecb3 100644
--- a/gst/gstdevicemonitor.c
+++ b/gst/gstdevicemonitor.c
@@ -695,12 +695,9 @@
   /* Ensure there is no leak here */
   g_assert (factories == NULL);
 
-  if (matched) {
+  if (matched)
     id = filter->id;
-    g_ptr_array_add (monitor->priv->filters, filter);
-  } else {
-    device_filter_free (filter);
-  }
+  g_ptr_array_add (monitor->priv->filters, filter);
 
   GST_OBJECT_UNLOCK (monitor);