commit e655d47dfce1652630fe8ff5fb6be56370087004
author Reynaldo H. Verdejo Pinochet <reynaldo@osg.samsung.com> Thu Sep 11 13:48:44 2014 -0300
committer Reynaldo H. Verdejo Pinochet <reynaldo@osg.samsung.com> Thu Sep 18 18:53:38 2014 -0300
tree 6ec336e79007c13ef589812721e7fc21834695da
parent ba4b9b22d000e269f595ecce7771bdec007ccdf0

isomp4: fix wrong DAR calculation for PAR <= 1

CID #1226452

https://bugzilla.gnome.org/show_bug.cgi?id=736396

gst/isomp4/atoms.c

diff --git a/gst/isomp4/atoms.c b/gst/isomp4/atoms.c
index 3f1051c..f8bf050 100644
--- a/gst/isomp4/atoms.c
+++ b/gst/isomp4/atoms.c
@@ -48,6 +48,7 @@
 #include <gst/gst.h>
 #include <gst/base/gstbytewriter.h>
 #include <gst/tag/tag.h>
+#include <gst/video/video.h>
 
 /**
  * Creates a new AtomsContext for the given flavor.
@@ -3483,7 +3484,7 @@
     VisualSampleEntry * entry, guint32 scale, GList * ext_atoms_list)
 {
   SampleTableEntryMP4V *ste;
-  gint dwidth, dheight;
+  guint dwidth, dheight;
   gint par_n = 0, par_d = 0;
 
   if ((entry->par_n != 1 || entry->par_d != 1) &&
@@ -3497,12 +3498,10 @@
   /* ISO file spec says track header w/h indicates track's visual presentation
    * (so this together with pixels w/h implicitly defines PAR) */
   if (par_n && (context->flavor != ATOMS_TREE_FLAVOR_MOV)) {
-    if (par_n > par_d) {
-      dwidth = entry->width * par_n / par_d;
-      dheight = entry->height;
-    } else {
-      dwidth = entry->width * par_n / par_d;
-      dheight = entry->height;
+    /* Assumes square pixels display */
+    if (!gst_video_calculate_display_ratio (&dwidth, &dheight, entry->width,
+            entry->height, par_n, par_d, 1, 1)) {
+      GST_WARNING ("Could not calculate display ratio");
     }
   }