commit d1a618cabf4f0dedf5d3a00f8702c004176baefd
author Nicolas Dufresne <nicolas.dufresne@collabora.com> Wed Aug 22 19:23:53 2018 +0000
committer Nicolas Dufresne <nicolas.dufresne@collabora.com> Fri Aug 31 16:01:46 2018 -0400
tree d6f0afcb8c48d4600537ab0c45209ccf6b474eec
parent ab1f4cc853b35cb06446fe9df8b58b38cfbb71b9

v4l2object: Only offer MMAP/DMABUF pool

The propose allocation was offering a pool even in DMABUF_IMPORT or
USERPTR mode. These pool are internal only.

sys/v4l2/gstv4l2object.c

diff --git a/sys/v4l2/gstv4l2object.c b/sys/v4l2/gstv4l2object.c
index 53139eb..5d3b691 100644
--- a/sys/v4l2/gstv4l2object.c
+++ b/sys/v4l2/gstv4l2object.c
@@ -4553,8 +4553,16 @@
   if (caps == NULL)
     goto no_caps;
 
-  if ((pool = obj->pool))
-    gst_object_ref (pool);
+  switch (obj->mode) {
+    case GST_V4L2_IO_MMAP:
+    case GST_V4L2_IO_DMABUF:
+      if ((pool = obj->pool))
+        gst_object_ref (pool);
+      break;
+    default:
+      pool = NULL;
+      break;
+  }
 
   if (pool != NULL) {
     GstCaps *pcaps;