commit 1f00a4b7ce3e82d511bbb7dc27e3e7059757ebbb
author Mathieu Duponchelle <mathieu@centricular.com> Fri Apr 13 22:49:43 2018 +0200
committer Sebastian Dröge <sebastian@centricular.com> Mon Apr 16 11:13:58 2018 +0300
tree 8c5b494fe4367acba903395193aff5c324d1619b
parent 59010ac580fe233310a79d849151c107d6168990

qtmux: Fix leak

gst_qt_mux_can_renegotiate () gets called everywhere following
that pattern:

return gst_qt_mux_can_renegotiate (ref(self));

This means the reference must be released both in the success
and failure cases, it was only done in the success case.

gst/isomp4/gstqtmux.c

diff --git a/gst/isomp4/gstqtmux.c b/gst/isomp4/gstqtmux.c
index 9a6cd7b..195fa2f 100644
--- a/gst/isomp4/gstqtmux.c
+++ b/gst/isomp4/gstqtmux.c
@@ -4857,6 +4857,7 @@
         "pad %s accepted renegotiation to %" GST_PTR_FORMAT " from %"
         GST_PTR_FORMAT, GST_PAD_NAME (pad), caps, current_caps);
     gst_caps_unref (current_caps);
+    gst_object_unref (qtmux);
 
     return TRUE;
   }
@@ -5233,6 +5234,7 @@
         "pad %s accepted renegotiation to %" GST_PTR_FORMAT " from %"
         GST_PTR_FORMAT, GST_PAD_NAME (pad), caps, current_caps);
     gst_caps_unref (current_caps);
+    gst_object_unref (qtmux);
 
     return TRUE;
   }
@@ -5775,6 +5777,7 @@
         "pad %s accepted renegotiation to %" GST_PTR_FORMAT " from %"
         GST_PTR_FORMAT, GST_PAD_NAME (pad), caps, current_caps);
     gst_caps_unref (current_caps);
+    gst_object_unref (qtmux);
 
     return TRUE;
   }