tree 2a1915b4a98c299e4a3fa3f5ab2b25a36a3f316c
parent 8e6b876e76c94410db160afe5eb30f21452e419f
author Tim-Philipp Müller <tim.muller@collabora.co.uk> 1298249749 +0000
committer Tim-Philipp Müller <tim.muller@collabora.co.uk> 1298286183 +0000

icydemux: fix tag list handling issues that might have caused crashes

Fix slightly confused tag handling in some places: make it clear when
we're taking ownership of a tag list and when not. For example,
gst_icydemux_tag_found() was taking ownership when the source pad
existed, but otherwise not (leak). Also, gst_event_parse_tag() does
not return a newly-allocated taglist, but a tag list that belongs to
the tag event, so don't give ownership of it away.

While we're at it, some minor clean-ups: don't re-invent g_strndup()
and simplify gst_icydemux_parse_and_send_tags() a bit, and don't
leak the tag list in case no valid tags where found.

https://bugzilla.gnome.org/show_bug.cgi?id=641330