commit 009d104a34de66aac9f2a0be360ca30ab4381b20
author Thiago Santos <thiago.sousa.santos@collabora.co.uk> Fri Nov 06 00:46:12 2009 -0300
committer Tim-Philipp Müller <tim.muller@collabora.co.uk> Tue Apr 12 20:32:13 2011 +0100
tree fe9ca3575d97bedf99e4614516e8d6d41b929da4
parent 4ff2fad6a07492a6419ae02742e474f33c907ac1

qtmux: Adding some ifs for protection

Adding somes ifs to protect against warning conditions
that might happen when upstream element is not sane

Fixes #600895

gst/quicktime/atoms.c

diff --git a/gst/quicktime/atoms.c b/gst/quicktime/atoms.c
index 838b50f..2f69098 100644
--- a/gst/quicktime/atoms.c
+++ b/gst/quicktime/atoms.c
@@ -2425,9 +2425,13 @@
 {
   trak->mdia.mdhd.time_info.duration =
       atom_stts_get_total_duration (&trak->mdia.minf.stbl.stts);
-  trak->tkhd.duration =
-      gst_util_uint64_scale (trak->mdia.mdhd.time_info.duration, moov_timescale,
-      trak->mdia.mdhd.time_info.timescale);
+  if (trak->mdia.mdhd.time_info.timescale != 0) {
+    trak->tkhd.duration =
+        gst_util_uint64_scale (trak->mdia.mdhd.time_info.duration,
+        moov_timescale, trak->mdia.mdhd.time_info.timescale);
+  } else {
+    trak->tkhd.duration = 0;
+  }
 }
 
 static guint32

gst/quicktime/gstqtmux.c

diff --git a/gst/quicktime/gstqtmux.c b/gst/quicktime/gstqtmux.c
index b52b871..41ea97f 100644
--- a/gst/quicktime/gstqtmux.c
+++ b/gst/quicktime/gstqtmux.c
@@ -1126,7 +1126,7 @@
         GST_PAD_NAME (qtpad->collect.pad));
     ret = gst_qt_mux_add_buffer (qtmux, qtpad, NULL);
     if (ret != GST_FLOW_OK)
-      GST_DEBUG_OBJECT (qtmux, "Failed to send last buffer for %s, "
+      GST_WARNING_OBJECT (qtmux, "Failed to send last buffer for %s, "
           "flow return: %s", GST_PAD_NAME (qtpad->collect.pad),
           gst_flow_get_name (ret));
   }
@@ -1405,7 +1405,8 @@
     GST_ELEMENT_ERROR (qtmux, CORE, NEGOTIATION, (NULL),
         ("format wasn't negotiated before buffer flow on pad %s",
             GST_PAD_NAME (pad->collect.pad)));
-    gst_buffer_unref (buf);
+    if (buf)
+      gst_buffer_unref (buf);
     return GST_FLOW_NOT_NEGOTIATED;
   }
 }