commit de01c27a8b508442fdf46ef20a0d299ba3da8312
author Luiz Augusto von Dentz <luiz.von.dentz@intel.com> Fri Apr 28 21:20:51 2017 +0300
committer Luiz Augusto von Dentz <luiz.von.dentz@intel.com> Tue May 02 14:22:37 2017 +0300
tree f744183d16baf6bdb204da8b34187c1ca7a5a5b6
parent e60516495a21299abe8335b1e652846ebc302a8a

shared/att: Respond to any opcode that is not command

Although get_op_type does now check for the command mask it must
respond to anything other than ATT_OP_TYPE_CMD since there is no mask
for response opcode.

src/shared/att.c

diff --git a/src/shared/att.c b/src/shared/att.c
index 494b10d..ca2d051 100644
--- a/src/shared/att.c
+++ b/src/shared/att.c
@@ -149,7 +149,7 @@
 	}
 
 	if (opcode & ATT_OP_CMD_MASK)
-		return ATT_OP_CMD_MASK;
+		return ATT_OP_TYPE_CMD;
 
 	return ATT_OP_TYPE_UNKNOWN;
 }
@@ -841,10 +841,10 @@
 	}
 
 	/*
-	 * If this was a request and no handler was registered for it, respond
-	 * with "Not Supported"
+	 * If this was not a command and no handler was registered for it,
+	 * respond with "Not Supported"
 	 */
-	if (!found && get_op_type(opcode) == ATT_OP_TYPE_REQ)
+	if (!found && get_op_type(opcode) != ATT_OP_TYPE_CMD)
 		respond_not_supported(att, opcode);
 
 	bt_att_unref(att);