commit c2659e72d7723f8dcb8659a1cb1d8ff3d6edae88
author Kévin PETIT <kevin.petit@arm.com> Mon Feb 24 14:20:37 2014 +0000
committer Kévin PETIT <kevin.petit@arm.com> Wed Feb 26 11:39:13 2014 +0000
tree 1f26f278af56222a5b56ce8b0caf1160cc03c045
parent ebb46d76e4bf4ee4f34b42709ea69cce07e3e322

Fix the handling of CodeCache return codes in pixelflinger

The error condition was not correctly detected: an error was
reported by checking that the index returned by CodeCache::cache
was non-zero. This did not work because this function can return
a positive value on success.

Change-Id: I1f90125ee62ab277b80da4dfb341733cd6e8e86a
Signed-off-by: Kévin PETIT <kevin.petit@arm.com>

libpixelflinger/scanline.cpp

diff --git a/libpixelflinger/scanline.cpp b/libpixelflinger/scanline.cpp
index cd78713..cb2b811 100644
--- a/libpixelflinger/scanline.cpp
+++ b/libpixelflinger/scanline.cpp
@@ -408,10 +408,10 @@
         GGLAssembler assembler( new ArmToArm64Assembler(a) );
 #endif
         // generate the scanline code for the given needs
-        int err = assembler.scanline(c->state.needs, c);
+        bool err = assembler.scanline(c->state.needs, c) != 0;
         if (ggl_likely(!err)) {
             // finally, cache this assembly
-            err = gCodeCache.cache(a->key(), a);
+            err = gCodeCache.cache(a->key(), a) < 0;
         }
         if (ggl_unlikely(err)) {
             ALOGE("error generating or caching assembly. Reverting to NOP.");